Allow zero-sized files #63
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were rejecting files of size zero; this may have been due to a past constraint within Permanent (and that constraint may still exist somewhere in the backend), but we ultimately do want to let people upload empty files since files of zero size can legitimately exist. Issue #62 Support zero-sized files
slifty
force-pushed
the
62-support-zero-sized-files
branch
from
75d8277 to
e3e2e4f
Compare
|
Converted this to draft since we're not working on it at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the validation to allow the creation of an S3 url for empty files.
I have not done investigation into the back end regarding where zero sized files might cause issues (e.g. in task runner, etc)
Resolves #62